Repository navigation
fix(skills): name the silent bake failure and check the bake result - #429
Merged
Merged
Conversation
bake-high-to-low said a missing UV layer or a non-active image node
"finishes without error". Measured on 4.5.11 LTS and 5.2.1 LTS: a
missing UV layer raises RuntimeError, a lone Image Texture node that is
not nodes.active is baked into anyway, and the case that really is
silent is a material with no Image Texture node, which returns
{'CANCELLED'} and raises nothing. The canonical call assigned `result`
and never looked at it.
The skill now tabulates the three measured behaviours, and both the
skill's canonical call and snippets/bake_normal_high_to_low.py raise
when the result is not {'FINISHED'}.
Closes #356
Signed-off-by: TMHSDigital <154358121+TMHSDigital@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Owner
Author
|
CI evidence before merge: all checks pass ( 13 pass ). Blender Smoke on PR head: Blender 5.2.2 LTS / Blender 4.5.14 LTS. Summaries (happy path; falsifiers) per leg: 143 passed, 1 skipped, 0 failed;143 passed, 0 skipped, 0 failed;141 passed, 3 skipped, 0 failed;136 passed, 7 skipped, 0 failed; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #356.
Measured
Live run,
--factory-startup, Cycles CPU, 1 sample, a cube bake set up as the skill describes. Binaries report 5.2.1 LTS and 4.5.11 LTS; results are identical on both:bpy.ops.object.bake(...){'FINISHED'}; image written (blue mean 1.0)RuntimeError: Error: No active UV layer found in the object "Low"nodes.active{'FINISHED'}; still baked into it (blue mean 1.0){'CANCELLED'}, no exception, nothing writtenThe skill had claimed the UV and non-active-node cases "finish without error". The truly silent one is the missing image node, which nothing checked.
Change
result != {'FINISHED'}.snippets/bake_normal_high_to_low.py: raises on a non-FINISHEDresult and returns it otherwise (36 lines).Evidence for the snippet change (live, both versions)
{'FINISHED'}.RuntimeError bake did not finish: {'CANCELLED'}. Before this change it returned{'CANCELLED'}silently.check_frontmatterpasses.🤖 Generated with Claude Code