Skip to content

fix(site): visible focus on selected filters, arrow keys stay in code blocks, pager polish - #423

Merged
TMHSDigital merged 1 commit into
mainfrom
fix/gallery-a11y
Oct 5, 2026
Merged

TMHSDigital merged 1 commit into
mainfrom
fix/gallery-a11y

Conversation

@TMHSDigital

Copy link
Copy Markdown
Owner

Closes #397, #398, #399.

Changes (scripts/build_gallery.py, scripts/site/template.html.j2; gallery regenerated)

Evidence (live browser: Playwright against docs/ served locally, after build_gallery.py + build_site.py)

Check Result
Tab from search onto the selected "All" button :focus-visible true. Computed solid 2px rgb(26,27,30) at offset −4px on rgb(255,140,25). Element screenshot shows a clear dark inset ring
vertex-color-ao: click the run block, press → Focus lands on #runCmd; URL unchanged
Same, with the block forced to overflow (2882 px) → scrolls it (scrollLeft 23); URL unchanged
Nothing focused (click the h1, no selection), press → Navigates to /gallery/cross-version-property-delete/, as before
bmesh-gear at 375 px, all 4 pager links Label truncated, arrow box fully inside the link; screenshot shows ← driver-wa… and shader-no… →
Gallery first card fetchpriority="high"; desktop placeholder keeps "(press /)"
python tests/check_site_links.py 135 pages, 0 failures

Not exercised: the touch placeholder branch (no (hover: none) emulation). It is a single matchMedia check.

🤖 Generated with Claude Code

@github-actions github-actions Bot added the documentation Improvements or additions to documentation label Oct 5, 2026
… blocks, pager polish

- #397: an orange focus ring on an orange selected button was invisible
  (14 changed pixels). Selected kind, category and chip buttons now get a
  2px dark inset ring (--on-select on --select, about 7.8:1).
- #398: clicking a wide code block did not move focus, so ArrowRight
  navigated to the next gallery page. <pre> blocks are now focusable
  (tabindex=0, which also gives keyboard scrolling), and the pager keys
  stand down while the last click is inside a block that scrolls sideways.
- #399: the pager's next arrow was clipped with the truncated name at
  375px; the name now truncates in its own span. The first gallery card
  (the LCP image) gets fetchpriority=high; touch devices drop the "/" hint
  from the search placeholder; the gallery search and the landing filter
  inputs get name/id attributes.

Closes #397
Closes #398
Closes #399

Signed-off-by: TMHSDigital <154358121+TMHSDigital@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@TMHSDigital

Copy link
Copy Markdown
Owner Author

CI evidence before merge: all checks pass ( 13 pass ). Blender Smoke on PR head: Blender 5.2.2 LTS / Blender 4.5.14 LTS. Summaries (happy path; falsifiers) per leg: 143 passed, 1 skipped, 0 failed;143 passed, 0 skipped, 0 failed;141 passed, 3 skipped, 0 failed;136 passed, 7 skipped, 0 failed;

@TMHSDigital
TMHSDigital merged commit 5891799 into main Oct 5, 2026
13 checks passed
@TMHSDigital
TMHSDigital deleted the fix/gallery-a11y branch October 5, 2026 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

site: keyboard focus ring is invisible on selected gallery filter buttons (orange outline on orange fill)

1 participant