Repository navigation
fix(site): visible focus on selected filters, arrow keys stay in code blocks, pager polish - #423
Merged
Merged
Conversation
… blocks, pager polish - #397: an orange focus ring on an orange selected button was invisible (14 changed pixels). Selected kind, category and chip buttons now get a 2px dark inset ring (--on-select on --select, about 7.8:1). - #398: clicking a wide code block did not move focus, so ArrowRight navigated to the next gallery page. <pre> blocks are now focusable (tabindex=0, which also gives keyboard scrolling), and the pager keys stand down while the last click is inside a block that scrolls sideways. - #399: the pager's next arrow was clipped with the truncated name at 375px; the name now truncates in its own span. The first gallery card (the LCP image) gets fetchpriority=high; touch devices drop the "/" hint from the search placeholder; the gallery search and the landing filter inputs get name/id attributes. Closes #397 Closes #398 Closes #399 Signed-off-by: TMHSDigital <154358121+TMHSDigital@users.noreply.github.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
TMHSDigital
force-pushed
the
fix/gallery-a11y
branch
from
October 5, 2026 00:38
ed22f05 to
ec69966
Compare
Owner
Author
|
CI evidence before merge: all checks pass ( 13 pass ). Blender Smoke on PR head: Blender 5.2.2 LTS / Blender 4.5.14 LTS. Summaries (happy path; falsifiers) per leg: 143 passed, 1 skipped, 0 failed;143 passed, 0 skipped, 0 failed;141 passed, 3 skipped, 0 failed;136 passed, 7 skipped, 0 failed; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #397, #398, #399.
Changes (
scripts/build_gallery.py,scripts/site/template.html.j2; gallery regenerated)outline: 2px solid var(--on-select); outline-offset: -4px. That's a dark inset ring on the orange fill (#1a1b1e on #ff8c19 ≈ 7.8:1). Unselected buttons are unchanged.<pre>blocks gettabindex="0", so a click focuses them and the keyboard can scroll them;pointerdownlanded in apre/.code-lines/.codewrapthat overflows horizontally..pager-labelspan, so the ← / → stays visible at 375 px;fetchpriority="high";(hover: none)the search placeholder drops "(press /)";name/id, which clears the DevTools form-field issue.onScroll(), which was the reviewer's lowest item.Evidence (live browser: Playwright against
docs/served locally, afterbuild_gallery.py+build_site.py):focus-visibletrue. Computedsolid 2px rgb(26,27,30)at offset −4px onrgb(255,140,25). Element screenshot shows a clear dark inset ring#runCmd; URL unchangedscrollLeft23); URL unchanged/gallery/cross-version-property-delete/, as before← driver-wa…andshader-no… →fetchpriority="high"; desktop placeholder keeps "(press /)"python tests/check_site_links.pyNot exercised: the touch placeholder branch (no
(hover: none)emulation). It is a singlematchMediacheck.🤖 Generated with Claude Code