Repository navigation
fix(gallery): render inline code in callouts; add the asset-sheet gate to the example prompt - #422
Merged
Merged
Conversation
…e to the example prompt
The parent-inverse-orrery witness callout showed raw markdown
("Bare `.parent =` ...") because build_gallery.py only html-escaped the
teaches and witnessesFix text. Both now render backtick spans as <code>,
like the landing page's inline_code; alt text, an attribute that cannot
carry markup, now fails the build if it contains a backtick.
docs/new-example-prompt.md covered the contact-sheet gate but never the
asset-sheet gate CLAUDE.md requires for asset-type examples (three of the
pinned asset references are examples). It now describes the gate, the
SELECT row it needs, and the asset-quality floors.
Closes #368
Signed-off-by: TMHSDigital <154358121+TMHSDigital@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
github-actions
Bot
added
the
documentation
Owner
Author
|
CI evidence before merge: all checks pass ( 13 pass ). Blender Smoke on PR head: Blender 5.2.2 LTS / Blender 4.5.14 LTS. Summaries (happy path; falsifiers) per leg: 141 passed, 3 skipped, 0 failed;136 passed, 6 skipped, 0 failed;143 passed, 1 skipped, 0 failed;142 passed, 0 skipped, 0 failed; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #368. Items 1 and 3 are here; item 2, the
showcase/README.mdpath-filter claim, was fixed in #413.Changes
scripts/build_gallery.py:inline_code(): escapes, then renders backtick spans as<code>, mirroringscripts/site/build_site.py. Unbalanced backticks stay literal;teachesandwitnessesFixon cards, related cards and detail pages;check_alts()rejects a backtick inalt, an attribute where<code>can't exist and the backtick would be read aloud.docs/new-example-prompt.md: a new "Asset-sheet gate" paragraph. It covers when the gate applies, thescripts/asset_sheet.pycommand, theSELECTrow it needs, the commit location, the verdict rule, and thegallery_asset_quality.pyfloors (exit 11). Membership stays canonical in CLAUDE.md.Evidence (generated HTML read, per CLAUDE.md)
python scripts/build_gallery.py, only two pages change:docs/gallery/index.htmlanddocs/gallery/parent-inverse-orrery/index.html. Both now containBare <code>.parent =</code> really does teleport the child.grep -c 'Bare \' docs/gallery/index.htmlgives 0. No othergallery.json` entry contains a backtick, so no other page changed.python tests/check_site_links.py: 135 pages, 0 failures.🤖 Generated with Claude Code