Repository navigation
fix(skills): correct four API claims that make agent code silently wrong - #410
Merged
Merged
Conversation
- use-foreach-set rule listed vertex "normal" and "index" as foreach_set targets; both are read-only and foreach_set on them is a silent no-op. It now names writable attributes and says how to read and write normals. - geometry-nodes-python told agents to list node types with GeometryNode.__subclasses__(), which returns [] because bpy.types classes are created lazily. Use dir(bpy.types) instead. - engine-export-presets said glTF infers the format from the filepath suffix. It does not: a .gltf path with no export_format writes .glb. The skill now says to always pass export_format, and every glTF call in the snippets, presets and pipeline template passes it. - drivers-and-app-handlers' save-count example keyed an ID property by the full path (KeyError past 63 characters) and counted in save_post, after the file was written. It now keys by basename and uses save_pre. Closes #353 Closes #355 Closes #388 Closes #390 Signed-off-by: TMHSDigital <154358121+TMHSDigital@users.noreply.github.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Owner
Author
|
CI evidence before merge: all checks pass ( 13 pass ). Blender Smoke on PR head: Blender 5.2.2 LTS / Blender 4.5.14 LTS. Summaries (happy path; falsifiers) per leg: 143 passed, 1 skipped, 0 failed;142 passed, 0 skipped, 0 failed;141 passed, 3 skipped, 0 failed;136 passed, 6 skipped, 0 failed; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #353, #355, #388, #390.
use-foreach-setrule"normal"and"index"asforeach_settargets; there was also a duplicatedforeach_getlineclaude/regenerated:--checkis clean, and the change falls outside the generated summarygeometry-nodes-pythonGeometryNode.__subclasses__()(returns[]; classes are lazy)dir(bpy.types)filter, with the reasonengine-export-presetsexport_format. Addedexport_format="GLB"to every glTF call insnippets/export_preset_{unity,godot,unreal}.py,snippets/gltf_draco_export.py, the pipeline template (×3) and the skill's code blocksdrivers-and-app-handlerssave countsave_postsave_pre, so the count is in the file being savedEvidence
Proven by live run (
--factory-startup; binaries report 5.2.1 LTS and 4.5.11 LTS). Each result is identical on both versions unless the table shows two values.dir(bpy.types)GeometryNode names (includes SetPosition)save_as+save+ reopen{'a_rather_long_production_shot_name_xxx…': 2}, persisted, no KeyErrorexport_format="GLB"→.glbt_GLB.glbexport_format="GLTF_SEPARATE"→.gltf.gltf+.binexport_format,.gltfpatht_None.glb(the bug the skill now warns about)vertices.foreach_set("normal", …)changes nothingBy inspection only:
export_format="GLB"matches the operator's existing default for these.glbcall sites, so output is unchanged. The pipeline template and the export-preset examples run in CI smoke.🤖 Generated with Claude Code