Skip to content

Fix(fix/Default_pro): fix install first pro script #326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
linushuan wants to merge 2 commits into from
Closed

Fix(fix/Default_pro): fix install first pro script #326

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
356e08f
Fix(fix/Default_pro): fix install first pro script
linushuan Sep 26, 2026
3dfbcf1
Update database password retrieval in runserver.sh
linushuan Sep 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion scripts/runserver.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,10 @@ until pg_isready -h ${DB_CONTAINER_NAME} -p 5432; do
done

should_install_first_problem=false
if [[ -f docker-dev || -f docker-release ]] && [ -d static-tmp ]; then
PROBLEM_COUNT=$(PGPASSWORD="$(sed -n 's/^DB_PASSWORD=//p' scripts/.docker-init.env)" psql -h "${DB_CONTAINER_NAME}" -U ntoj -d ntoj -tAc "SELECT count(*) FROM problem" 2>/dev/null || echo "0")

@uyo9 uyo9 Sep 27, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.docker-init.env is deleted by docker-init, thereby causing the not found error once I don't restart the container:

sed: can't read scripts/.docker-init.env: No such file or directory

NTOJ/scripts/docker-init.sh

Line 50 in fa96592

rm scripts/.docker-init.env

PROB_COUNT=$(echo "$PROB_COUNT" | xargs)

@uyo9 uyo9 Sep 27, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PROBLEM_COUNT


if [[ -f docker-dev || -f docker-release ]] && [ -d static-tmp ] && [ "$PROBLEM_COUNT" -eq 0 ]; then
should_install_first_problem=true

@uyo9 uyo9 Sep 27, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PROBLEM_COUNT check should be separated from docker-init:

if [[ -f docker-dev || -f docker-release ]] && [ -d static-tmp ]; then
    if [ "$PROBLEM_COUNT" -eq 0 ]; then
        should_install_first_problem=true
    fi
    
    ./scripts/docker-init.sh
fi

Otherwise, it causes the following error:

cp: cannot stat 'config.py': No such file or directory

./scripts/docker-init.sh
fi
Expand Down
Loading