feat(tts): add language to vendor metadata - #2295
Closed
wangyimin-agora wants to merge 1 commit into
Closed
Conversation
Contributor
Author
|
Closing this fork-based PR; it will be replaced by a PR from the upstream dev/tts_language branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
languageto Rime and OpenAI TTS vendor metadata.vendor_info.vendor.tts_flush_endwhile continuing to reject audio frames.Why
Adding language made exact metadata comparisons fail even though the required metadata remained correct. The connection-status test also expected an outdated top-level
vendorfield, and the flush test treated valid non-audio events as extra output.Validation
test_flushandtest_connection_statuspassed (2 passed).13 passed,1 skipped, with the unrelated empty-text latency case still failing its 500 ms threshold.4 passed).git diff --check.