docs: add version bump and guarder evidence to extension pr checklist - #2279
Open
BenWeekes wants to merge 3 commits into
Open
docs: add version bump and guarder evidence to extension pr checklist#2279BenWeekes wants to merge 3 commits into
BenWeekes wants to merge 3 commits into
Conversation
reviewers request these on every asr/tts extension pr: bump the version in both manifest.json and pyproject.toml, and attach the guarder test result to the pr as a comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two items reviewers consistently request on ASR/TTS extension PRs but the pre-submission checklist omits:
manifest.jsonandpyproject.tomlfor any change to an existing extensionAdding them at the top of the checklist in
docs/ai/L1/L2/extension_development.mdso agents and contributors stop rediscovering this via review feedback.