Skip to content

fix(tests): use string form for shell=True subprocess.run in nodejs test start scripts #2245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
noron12234 wants to merge 1 commit into from
+5 −5
Closed

fix(tests): use string form for shell=True subprocess.run in nodejs test start scripts #2245

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ...e/integration/nodejs/standalone_test_nodejs_2/default_extension_nodejs/tests/bin/start.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,14 +16,14 @@

# npm install
print("Running npm install...")
result = subprocess.run(["npm", "install"], env=env, shell=True)
result = subprocess.run("npm install", env=env, shell=True)
if result.returncode != 0:
print("npm install failed")
sys.exit(result.returncode)

# npm run build
print("Running npm run build...")
result = subprocess.run(["npm", "run", "build"], env=env, shell=True)
result = subprocess.run("npm run build", env=env, shell=True)
if result.returncode != 0:
print("npm run build failed")
sys.exit(result.returncode)
Expand All @@ -50,5 +50,5 @@

# npm test
print("Running npm test...")
result = subprocess.run(["npm", "test"], env=env, shell=True)
result = subprocess.run("npm test", env=env, shell=True)
sys.exit(result.returncode)
4 changes: 2 additions & 2 deletions ...e/integration/nodejs/standalone_test_nodejs_3/default_extension_nodejs/tests/bin/start.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,14 +16,14 @@

# npm install
print("Running npm install...")
result = subprocess.run(["npm", "install"], env=env, shell=True)
result = subprocess.run("npm install", env=env, shell=True)
if result.returncode != 0:
print("npm install failed")
sys.exit(result.returncode)

# npm run build
print("Running npm run build...")
result = subprocess.run(["npm", "run", "build"], env=env, shell=True)
result = subprocess.run("npm run build", env=env, shell=True)
if result.returncode != 0:
print("npm run build failed")
sys.exit(result.returncode)
Expand Down