Repository navigation
perf: eliminate plot expansion server stalls - #26
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
/plx export,/plx importand DB-backed cache reload work off the server threadWhy
The chunk purchase transaction itself was already worker-side, but
ProtectionCoordinatorintentionally failed every protection decision while a purchase/mutation was in progress. As movement/interactions are protected through that coordinator, expanding one plot could cancel events server-wide and look exactly like a short lag spike or rollback. The new model keeps the last known-good immutable snapshot readable while the next version is persisted and published.Bukkit/WorldGuard/Vault operations that are not guaranteed thread-safe deliberately remain on the server thread; JDBC and cache loading do not.
Verification
The previous test failure was caused by an assertion explicitly requiring protection to be blocked during economy withdrawal. That assertion was updated to the new snapshot semantics. The full repository verification then passed.