Repository navigation
perf: isolate migration disk I/O from live server workload - #13
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Migration commands already delegate provider work to the dedicated migration executor, but the universal fallback scan can still stream up to the configured aggregate limit (1 GiB by default). Running that work on another thread prevents direct tick-thread blocking, but unrestricted reads can still saturate the same storage used by world saves and plugin databases, which presents as visible server lag.
The universal provider also rebuilt its filesystem plan during
migrate()immediately after the coordinator had already completed the mandatory inspection, causing another deep scan in the same migration pipeline.Changes
Bukkit/Paper state checks and UI dispatch intentionally remain on the proper server/entity scheduler. The expensive file scanning/copying continues on
authgatewayx-migration; this change additionally prevents that background worker from monopolizing disk bandwidth.The intended trade-off is lower impact on a live server at the cost of longer migration/inspection time for very large unmanaged plugin datasets.