Repository navigation
fix: read a table declaration whose table is quoted - #2
Merged
Merged
Conversation
synalog takes a table's real name in backticks when it is not a plain one (`public.Order Items`, `my-project.sales.orders`). The two patterns that read a declaration only knew `[\w.]+`: such a table lost its columns (`Predicate.columns`) and got the generic description. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The mark goes from 70% to 80% of its square canvas. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Synalog fences are named `synalog` and left to javascripts/synalog-highlight.js: Synalemma's tokenizer and colours, and lines wider than 80 characters formatted along the code. The other languages take the same colours through the theme's variables. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The examples are fenced `synalog` since the docs colour them; the tests still looked for `prolog` and found none. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
synalog takes a table's real name in backticks when it is not a plain one, for example
`public.Order Items`or`my-project.sales.orders`. The two patterns here that read a table declaration only accepted[\w.]+, so for such a table:Predicate.columnsreturned an empty list;table_descriptionfell back to "A table of the database."Both patterns now also accept a backticked name, and the description is built from the name without its backticks.
Related
Goes with SynaLinks/synalog#20, which widens what a quoted table name may hold (spaces, accents,
',:, parentheses). This change does not depend on it: hyphenated names such as`my-project.sales.orders`were already valid synalog and already misread here.Tests
pytest: 59 passed.Not changed
connect.py's stricter_DECLARATIONpattern (the one with(?P=args)) still matches only plain names.🤖 Generated with Claude Code