Skip to content

Check for fields name in UniqueConstraint attribute #1167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jkindly wants to merge 2 commits into
base: 1.15
Choose a base branch
from
Open

Check for fields name in UniqueConstraint attribute #1167

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
379a7f7
Check for fields name in UniqueConstraint attribute
jkindly Jul 13, 2026
7f442ff
Add unit tests
jkindly Jul 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/Bundle/EventListener/ORMTranslatableListener.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,9 @@ private function hasUniqueConstraint(ClassMetadata $metadata, array $columns): b
}

foreach ($metadata->table['uniqueConstraints'] as $constraint) {
if (!array_diff($constraint['columns'], $columns)) {
$constraintColumns = $constraint['columns'] ?? $constraint['fields'] ?? [];

if (!array_diff($constraintColumns, $columns)) {
return true;
}
}
Expand Down
72 changes: 71 additions & 1 deletion tests/Bundle/EventListener/ORMTranslatableListenerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,15 @@

namespace Bundle\EventListener;

use App\Entity\BookTranslation;
use App\Entity\BookTranslationInterface;
use Doctrine\ORM\EntityManagerInterface;
use Doctrine\ORM\EntityRepository;
use Doctrine\ORM\Event\LoadClassMetadataEventArgs;
use Doctrine\ORM\Mapping\ClassMetadata;
use Doctrine\ORM\Mapping\DefaultNamingStrategy;
use Doctrine\Persistence\Mapping\RuntimeReflectionService;
use Sylius\Bundle\ResourceBundle\EventListener\ORMTranslatableListener;
use Symfony\Bundle\FrameworkBundle\Test\KernelTestCase;

final class ORMTranslatableListenerTest extends KernelTestCase
Expand All @@ -30,8 +36,72 @@ public function testGettingTranslationRepositoryByItsInterface(): void
);
}

public function testItAddsTheTranslatableUniqueConstraintWhenAnotherOneUsesTheFieldsFormat(): void
{
self::bootKernel();

$metadata = $this->createTranslationClassMetadata([
'uniq_book_translation_title' => ['fields' => ['title']],
]);

$this->createListener()->loadClassMetadata(
new LoadClassMetadataEventArgs($metadata, $this->getEntityManager()),
);

$uniqueConstraints = $metadata->table['uniqueConstraints'];

$this->assertArrayHasKey('uniq_book_translation_title', $uniqueConstraints);
$this->assertArrayHasKey('app_book_translation_uniq_trans', $uniqueConstraints);
$this->assertSame(
['translatable_id', 'locale'],
$uniqueConstraints['app_book_translation_uniq_trans']['columns'],
);
}

public function testItAddsTheTranslatableUniqueConstraintWhenAnotherOneUsesTheLegacyColumnsFormat(): void
{
self::bootKernel();

$metadata = $this->createTranslationClassMetadata([
'uniq_book_translation_title' => ['columns' => ['title']],
]);

$this->createListener()->loadClassMetadata(
new LoadClassMetadataEventArgs($metadata, $this->getEntityManager()),
);

$uniqueConstraints = $metadata->table['uniqueConstraints'];

$this->assertArrayHasKey('uniq_book_translation_title', $uniqueConstraints);
$this->assertArrayHasKey('app_book_translation_uniq_trans', $uniqueConstraints);
$this->assertSame(
['translatable_id', 'locale'],
$uniqueConstraints['app_book_translation_uniq_trans']['columns'],
);
}

/**
* @param array<string, array{columns?: array<string>, fields?: array<string>}> $uniqueConstraints
*/
private function createTranslationClassMetadata(array $uniqueConstraints): ClassMetadata
{
$metadata = new ClassMetadata(BookTranslation::class, new DefaultNamingStrategy());
$metadata->wakeupReflection(new RuntimeReflectionService());
$metadata->setPrimaryTable([
'name' => 'app_book_translation',
'uniqueConstraints' => $uniqueConstraints,
]);

return $metadata;
}

private function createListener(): ORMTranslatableListener
{
return self::getContainer()->get(ORMTranslatableListener::class);
}

private function getEntityManager(): EntityManagerInterface
{
return $this->getContainer()->get(EntityManagerInterface::class);
return self::getContainer()->get(EntityManagerInterface::class);
}
}
Loading