build: upgrade Flink from 1.18.1 to 1.20.5 - #248
Merged
pallakartheekreddy merged 2 commits intoAug 12, 2026
Conversation
romitshah02
marked this pull request as ready for review
August 11, 2026 11:46
sntiwari1
reviewed
Aug 11, 2026
sntiwari1
left a comment
Contributor
There was a problem hiding this comment.
Summary
Clean, well-scoped Flink 1.18.1 → 1.20.5 upgrade. The core migration pattern — dropping flink-streaming-scala (removed in Flink 2.0) for flink-streaming-java/Java DataStream, switching OutputTag construction to the explicit (name, TypeInformation) constructor now that the implicit Scala macro is gone, and widening Iterable[I] → java.lang.Iterable[I] in the WindowBaseProcessFunction/TimeWindowBaseProcessFunction process() signatures — is applied consistently across every job module (lms-jobs, ml-jobs, notification, user-org-jobs). I verified:
- No leftover references to
org.apache.flink.streaming.api.scalaorflink-streaming-scalaanywhere in the tree (git grepclean). WindowBaseProcessFunction/TimeWindowBaseProcessFunctionhave no subclasses in the repo, so the breakingprocess()signature change is safe.- The
stringTypeInfo/notificationMetaTypeInfo/userFeeMetaTypeInfoimplicits referenced by the newOutputTagconstructors are already declared in each touched config class, so nothing is missing. flink-connector-kafka:3.4.0-1.20usage inFlinkKafkaConnectoralready relies on theKafkaSourcebuilder API (not the legacyFlinkKafkaConsumer), so no additional migration is needed there.- The
add-jira-descriptionCI failure on this PR is an unrelated Jira automation check, not a build/test failure — no CI job actually compiles/tests this PR currently.
Only minor, non-blocking observations below — nothing I'd hold the merge for.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrades Apache Flink from 1.18.1 to 1.20.5 across all job modules. Migrates off the deprecated
flink-streaming-scalaAPI (removed in Flink 2.0) toflink-streaming-java/Java DataStream types, bumpsflink-connector-kafkato3.4.0-1.20, and fixes a stale log4j pin in the Docker image that crashed the TaskManager on startup against the new base image.Dependencies required:
org.apache.flink:flink-connector-kafka:3.4.0-1.20,org.apache.flink:flink-streaming-java:1.20.5(replacingflink-streaming-scala_2.12), log4j22.24.3(matches what Flink 1.20.5 already bundles).Type of change
Please choose appropriate options.
Checklist: