Skip to content

ALL-481: updated the responsive text line-height for M9 - #993

Open
Imtiyaz-Jiwani-16 wants to merge 3 commits into
Sunbird-ALL:all-3.0.6from
Imtiyaz-Jiwani-16:all-UI
Open

ALL-481: updated the responsive text line-height for M9#993
Imtiyaz-Jiwani-16 wants to merge 3 commits into
Sunbird-ALL:all-3.0.6from
Imtiyaz-Jiwani-16:all-UI

Conversation

@Imtiyaz-Jiwani-16

@Imtiyaz-Jiwani-16 Imtiyaz-Jiwani-16 commented Jul 20, 2026

Copy link
Copy Markdown
Collaborator

updated the responsive text line-height for M9

Summary by CodeRabbit

  • Style
    • Improved text spacing in word and sentence displays.
    • Added responsive line heights for better readability across mobile and desktop screen sizes.

@coderabbitai

coderabbitai Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Walkthrough

Responsive lineHeight values were added to word and highlighted sentence Typography components, using 1.4 on extra-small screens and 4.5rem from the medium breakpoint.

Changes

Responsive Typography

Layer / File(s) Summary
Responsive line-height rendering
src/components/Mechanism/WordsOrImage.jsx, src/views/Practice/Practice.jsx
Word and highlighted sentence Typography components now use breakpoint-specific line heights: 1.4 on xs and 4.5rem on md.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested reviewers: gouravmore, swayangjit

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the PR’s main change: making M9 text line-height responsive.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/views/Practice/Practice.jsx`:
- Line 3768: Update both Typography components in the type === "char" || type
=== "word" branch to use the same responsive lineHeight configuration as the
sentence branch instead of fixed "50px". Preserve the existing rendering
behavior and styling otherwise.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 53ce342f-2df4-49d7-a524-7baaaefd2ae1

📥 Commits

Reviewing files that changed from the base of the PR and between 5c9493e and 952ea3f.

📒 Files selected for processing (2)
  • src/components/Mechanism/WordsOrImage.jsx
  • src/views/Practice/Practice.jsx

Comment thread src/views/Practice/Practice.jsx
@sonarqubecloud

Copy link
Copy Markdown

@Imtiyaz-Jiwani-16
Imtiyaz-Jiwani-16 changed the base branch from all-3.0.6 to all-3.0.6-hotfix July 20, 2026 11:45
@Imtiyaz-Jiwani-16
Imtiyaz-Jiwani-16 changed the base branch from all-3.0.6-hotfix to all-3.0.6 July 20, 2026 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant