Return login expiration times from tyler auth response#402
Open
rajeswari1301 wants to merge 2 commits into
Open
Return login expiration times from tyler auth response#402rajeswari1301 wants to merge 2 commits into
rajeswari1301 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tyler already sends back an
ExpirationDateTimein the auth response - we just weren't passing it through.Added a
LoginResultrecord to carry both the tokens and expiry out of TylerLogin, threaded it throughSecurityHub, and surfaced it as a separate expirationTimes field inNewTokensso clients can see it in the response.Updated
SecurityHubTestto set the expiry on the mock and assert it comes back correctly.