Repository navigation
security(keeper): reject non-GET methods on keeper status with 405 - #563
Merged
karagozemin merged 1 commit intoOct 27, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GETHTTP methods (POST,PUT,PATCH,DELETE,HEAD,OPTIONS) at the top ofcreateStatusHandlerinservices/keeper/src/status-server.tswith HTTP405 Method Not Allowed, anAllow: GETresponse header, and a structured JSON error body ({ error: "method not allowed", method, allow: ["GET"], available }).send()inservices/keeper/src/status-server.tsto accept optional extra headers alongsidecontent-type: application/jsonandcache-control: no-store.http.Serverboundary tests inservices/keeper/src/status-server.test.tscoveringGETroutes as well asPOST,PUT,PATCH,DELETE,HEAD, andOPTIONSrequests across/,/status,/status/rounds/:id,/status/health, and/healthz.GET-only HTTP method policy (405 Method Not Allowed+Allow: GET) inservices/keeper/README.md.Supply-chain review
.vscode/, workflow, or other editor/config file changes. If changed, list them below.preinstall/postinstall) was added.Testing
node --import tsx --test src/status-server.test.tsinservices/keeper(13/13 tests pass, includingrejects non-GET methods with 405 and Allow: GET at the server boundary)node scripts/check-direct-time-access.mjs(passes)node scripts/check-links.js(passes)Closes #543
Fixes #543