Fix CPU spin on half-closed WebSocket / silent body truncation#828
Merged
Conversation
readPostData aborts silently on EOF or cancellation, leaving the caller with a zero-filled buffer and no indication that the read was short. In WebSocket.readBytes / readBytesIntoByteSegment this caused the frame parser to see opcode=0 length=0 (a zero-length Continuation frame), return immediately, and loop forever - pegging a CPU core after the peer half-closed the connection. In ConnectionFacade.getRawPostData the same bug silently truncated HTTP/1 request bodies, returning Ok with a partially-zeroed buffer instead of surfacing the broken connection. The HTTP/2 reader (Http2.readBytes) already guards against this with an 'if offset = n' check; apply the same fix to the other three call sites.
Member
Author
|
@copilot Can you produce a test that opens a TCP socket, sends a valid WebSocket upgrade, then half-closes — and asserts the handler exits within a deadline. |
Contributor
Added in 3ee47f6. There is now a regression test in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
readPostData aborts silently on EOF or cancellation, leaving the caller with a zero-filled buffer and no indication that the read was short.
In WebSocket.readBytes / readBytesIntoByteSegment this caused the frame parser to see opcode=0 length=0 (a zero-length Continuation frame), return immediately, and loop forever - pegging a CPU core after the peer half-closed the connection.
In ConnectionFacade.getRawPostData the same bug silently truncated HTTP/1 request bodies, returning Ok with a partially-zeroed buffer instead of surfacing the broken connection.
The HTTP/2 reader (Http2.readBytes) already guards against this with an 'if offset = n' check; apply the same fix to the other three call sites.
Added a regression test in
src/Suave.Tests/WebSocket.fsthat opens a raw TCP socket, performs a valid WebSocket upgrade handshake, half-closes the client send side, and asserts the handler exits within a deadline.