Skip to content

Fixed sound that could be heard from much too far away on certain maps. #362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Vitroze wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fixed sound that could be heard from much too far away on certain maps. #362

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d3b615e
Fixed sound that could be heard from much too far away on certain maps.
Vitroze Sep 16, 2026
9a62190
Remove distance attenuation calculation from EngineStream class
Vitroze Oct 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 19 additions & 7 deletions data_static/glide/web_audio_html.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,9 @@ debug.setValue = (id, value) => {
Logic to handle each individual Engine Stream
*/

let DEFAULT_STREAM_PARAMETERS = {};
let DEFAULT_STREAM_PARAMETERS = {
fadeDist: 2500
};

class EngineStream {
constructor(id, streamManager) {
Expand Down Expand Up @@ -196,13 +198,13 @@ class EngineStream {

this.pannerNode = new PannerNode(context, {
panningModel: "equalpower", //"HRTF",
distanceModel: "inverse",
distanceModel: "linear",
positionX: this.position[0],
positionY: this.position[1],
positionZ: this.position[2],
refDistance: this.params.fadeDist * 0.1,
refDistance: this.params.fadeDist * 0.5,
maxDistance: this.params.fadeDist,
rolloffFactor: 0.8
rolloffFactor: 1.0
});

this.pannerNode.channelCount = 1;
Expand Down Expand Up @@ -239,10 +241,11 @@ class EngineStream {
this.compressorNode = undefined;

// Remove references to data
this.layers = undefined;
this.layers = {};
this.position = undefined;
this.inputs = undefined;
this.params = undefined;
this.isPlaying = false;
}

setPosition(x, y, z) {
Expand All @@ -268,6 +271,13 @@ class EngineStream {

const layer = this.layers[id];

// Remove event handlers from the load request, if it exists
if (layer.loadRequest) {
layer.loadRequest.onload = null;
layer.loadRequest.onerror = null;
layer.loadRequest.onabort = null;
}

// Abort an existing download request, if it is active
if (layer.loadRequest && layer.loadRequest.readyState < 4) {
layer.loadRequest.abort();
Expand Down Expand Up @@ -386,8 +396,10 @@ class EngineStream {
const inputs = this.inputs;
const params = this.params;

this.pannerNode.refDistance = params.fadeDist * 0.1;
this.pannerNode.maxDistance = params.fadeDist;
if (params.fadeDist > 0) {
this.pannerNode.refDistance = params.fadeDist * 0.5;
this.pannerNode.maxDistance = params.fadeDist;
}

let baseVol = params.volume * this.volumeMultiplier;
let pitch = 1;
Expand Down
Loading