docs: record the flake fix (#53) in the round-16 log - #54
Merged
Merged
Conversation
PR #52 (docs-only) went red on check (22). This adds §21.3.4 for what that was and what was done about it, updates the 21.0 snapshot and the 21.8 delivery list to six PRs, and adds it as finding 10. The finding is worth its own entry because it is a category, not an incident: a gate that reds a docs-only change on a coin flip is a maintenance liability in its own right. Every discipline in this log — push, open a PR, wait for green before merging — rests on "green" carrying information, and a flaky test teaches the reader to re-run until it turns green instead. At that point green stops proving anything. So re-running to green would have been pushing the problem to the next round; removing the race is what this round owed. Records the evidence that it was a flake and not this host or an environment problem (same job passed on an unchanged re-run), the root cause read off the code rather than guessed (a single unsynchronised `status` read after `start`, plus two fixed sleeps that only lower the odds), and the honest verification split: the path is `it.skipIf(!ptyUsable)`, this machine cannot allocate a pty, so CI is the verification.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the round-16 log, which was written before its own CI produced one more finding.
PR #52 was docs-only and went red on
check (22). §21.3.4 records what that was (the PTY installer test), why it was a flake rather than an environment problem (the identical job passed on an unchanged re-run), the root cause read off the code (one unsynchronisedstatusread immediately afterstart, plus two fixed sleeps that only lower the odds), and the fix in #53 (bounded predicate polling).Also: §21.0 snapshot and §21.8 delivery updated to six PRs, and finding 10 added.
The finding earns its own entry because it is a category, not an incident — a gate that reds a docs-only change on a coin flip is a maintenance liability in its own right. This log's entire merge discipline is "wait for CI green before merging", and that is only meaningful while green carries information. A flaky test teaches "re-run until it turns green"; at that point green proves nothing and the whole verification line fails at once. Which is why "re-run it and merge" would have been deferring the problem rather than fixing it.
Docs-only.