Repository navigation
Test/unquarantine identity openapi - #1828
Merged
greatest0fallt1me merged 4 commits intoOct 24, 2026
Merged
greatest0fallt1me merged 4 commits into
greatest0fallt1me merged 4 commits into
Conversation
|
@Dev-Zwaylo Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
Held: this PR reverts already-merged request-id validation (#1778), hardcodes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1711.
Summary of Changes
Un-quarantine Suites:
<rootDir>/__tests__/openapi-auth-wallet.test.tsand<rootDir>/app/api/identity/me/route.test.tsfromtestPathIgnorePatternsinjest.config.js.OpenAPI Suite & Spec Updates:
__tests__/openapi-auth-wallet.test.tsto read the real repository root specification (openapi.json) withJSON.parse, eliminating the nonexistentsrc/openapi.yamlpath and dropping the undeclaredjs-yamldependency import.__tests__/openapi-auth-wallet.test.tsto verify thewalletChallengeGET 200 example against the response schema.openapi.jsonwith required examples:/api/auth/wallet: 200 (walletChallenge), 400, 422, 429/api/auth/wallet: requestBody (verifySignature), 200 (walletToken), 400, 401, 422, 429request_idnpm run openapi:generateandnpm run openapi:check.Identity Route & Contract Drift Fix:
app/api/identity/me/route.tsto look uplast_seenusingactor.walletAddress(matchingtouchLastSeenFromRequest's keying bysub).created_at: nulluntil persisted identity records exist, avoiding fake timestamps.User.created_atinapp/types/openapi.tstostring | null.app/api/identity/me/route.test.tsproving that whenactorId !== sub,last_seenis resolved correctly aftertouchLastSeenFromRequest, and assertingcreated_at: null.Observability Syntax Revert:
41017f8to fix syntax errors introduced onmainacrossapp/lib/auth.ts,app/lib/logger.ts,app/lib/rate-limit.ts,lib/rateLimitIp.ts, andapp/api/activity/route.ts.Test Plan & Results
Acceptance Criteria Verification
jest.config.js: both test paths removed fromtestPathIgnorePatternsSelect-String -Path "__tests__/openapi-auth-wallet.test.ts" -Pattern "openapi\.yaml|js-yaml": returns nothingnpx jest app/api/identity __tests__/openapi-auth-wallet: 2 suites, 16 tests passednpm run smoke: cleannpm run lint: cleannpm run build: clean