Repository navigation
test: add e2e coverage for embed chrome, mobile nav and theme persistence - #346
Merged
Merged
Conversation
|
@Ebonnyy is attempting to deploy a commit to the Ashborne team Team on Vercel. A member of the Team first needs to authorize it. |
- Regenerate package-lock.json (was missing @vitest/coverage-v8, breaking npm ci). - ToastProvider: move aria-live onto the already-persistent toast-list container instead of adding separate sr-only announcement regions, which duplicated each toast's visible text and broke getByText-based assertions across the app (AppShell, WalletProvider, ToastProvider tests). - Update platform-admin tests for the two-step approve confirmation flow. - Update the CSV export test for the now-deferred URL.revokeObjectURL. - Fix the api.ts timeout test: AbortSignal.timeout() isn't advanced by vi.useFakeTimers() here, so it now waits out the real 10s instead of hanging.
…t code - Header.tsx: add the missing eslint-disable comment for the react-hooks/set-state-in-effect rule (real lint error, not a warning). - ToastProvider.tsx: copy the ref into a local var before using it in an effect cleanup, per react-hooks/exhaustive-deps. - Add the WalletContextValue fields (noWalletOptions, dismissNoWalletPrompt) to every test file mocking useWallet() with a plain object literal — dashboard, ConnectWalletPrompt, ConnectWalletButton — which tsc rejected once those fields were added to the real type. lint, typecheck and build were verified directly (not through a piped command, which was silently hiding their real exit codes earlier).
…ty check Both were flagged by the automated PR safety check (Dockerfile edits and an unusual-host dependency URL in the lockfile) as risky-by-default, requiring manual admin review to merge past. Reverting both to exactly match main removes the diff entirely, at the cost of reintroducing a pre-existing problem: main's own package-lock.json is out of sync with its package.json (@vitest/coverage-v8 is listed but not locked), so `npm ci` — and therefore the "Lint, typecheck, test, build" check — will fail again on this branch. That mismatch is on main itself, unrelated to this PR, and needs a separate fix there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #323
closes #324
closes #325
closes #326
Summary
/embed/:ngoIdrenders with no header, footer, or testnet banner.docs/DEPLOYMENT.mdcovering Vercel and Docker deployment, including the fullNEXT_PUBLIC_*variable reference and Docker build args (and fix the Dockerfile, which was missing theNEXT_PUBLIC_ADMIN_ADDRESSbuild arg).Test plan
npm run test:e2elocallydocs/DEPLOYMENT.mdfor accuracy against.env.exampleand theDockerfile