Skip to content

Refactor/consistent ttl names - #228

Open
morris-the-dev wants to merge 3 commits into
StreamGive:mainfrom
morris-the-dev:refactor/consistent-ttl-names
Open

morris-the-dev wants to merge 3 commits into
StreamGive:mainfrom
morris-the-dev:refactor/consistent-ttl-names

Conversation

@morris-the-dev

Copy link
Copy Markdown
Contributor

Summary

Renames TTL extension entry points across both contracts for naming consistency and alignment with Soroban SDK conventions:

  • Renamed extend_stream to bump_stream_ttl in contracts/donation-vault/src/lib.rs.
  • Renamed touch_ngo to bump_ngo_ttl in contracts/ngo-registry/src/lib.rs.
  • Updated associated tests in contracts/donation-vault/src/test.rs and contracts/ngo-registry/src/test.rs.
  • Added test coverage for bump_stream_ttl on non-existent stream IDs.
  • Updated documentation in README.md and docs/STORAGE.md.

Type of change

  • Bug fix
  • New feature/functionality
  • Refactor (no functional change)
  • Documentation only
  • Contract storage/upgrade change

Related Issues

Closes #128

@drips-wave

drips-wave Bot commented Sep 30, 2026

Copy link
Copy Markdown

@morris-the-dev Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@Ashborne267

Copy link
Copy Markdown
Contributor

@morris-the-dev please resolve conflicts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rename extend_stream and touch_ngo to bump_stream_ttl and bump_ngo_ttl

3 participants