Remove stale bait-price GOALS entry from PLANNING.md - #131
Merged
Conversation
Player.priceForBait persistence, schema validation, and the 1.25x escalation on purchase are all implemented and covered by tests, so the note no longer describes a reproducible bug. Closes #122
Member
Author
|
Self-review rubric:
Repo-specific rubric (n/a — docs-only change, no persisted fields, money display, randomness, pygame, or naming touched):
Note on local verification: this sandbox couldn't set env-var-prefixed commands ( Summary: this is a documentation-accuracy fix closing #122 — no behavior change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PLANNING.md's only GOALS entry ("FISH LOADING BAIT PRICE BUG") is stale:Player.priceForBaitround-trips correctly throughPlayerJsonReaderWriter, is declared inschemas/player.json, and its 1.25x escalation on purchase (src/location/shop.py) is covered by tests. No reproducible bug exists against current code.Test plan
python3 -m compileall -q srcpython3 -m pytest -q— 370 passed locally; the 32 failures are pre-existing pygame-display tests that need theSDL_VIDEODRIVER=dummy/SDL_AUDIODRIVER=dummyenv vars this sandbox couldn't set (env-var-prefixed commands require approval not available in this run). This PR only touchesPLANNING.md, so these are unrelated to the change; CI sets those env vars itself and is the real anchor here.Closes #122