Skip to content

implemented XDR transaction builder with fee estimation#56

Open
dubemoyibe-star wants to merge 1 commit into
StepFi-app:mainfrom
dubemoyibe-star:feat/XDR-transaction-builder
Open

implemented XDR transaction builder with fee estimation#56
dubemoyibe-star wants to merge 1 commit into
StepFi-app:mainfrom
dubemoyibe-star:feat/XDR-transaction-builder

Conversation

@dubemoyibe-star

Copy link
Copy Markdown

Stellar Transaction Fee Handling Improvement

Problem

The API builds unsigned Stellar XDR transactions without proper fee estimation.
This leads to transactions being rejected by the Stellar network when fees are insufficient.


Solution

This update introduces proper fee estimation and retry handling for Stellar transactions.

Key Improvements

  • Added a dedicated transaction builder service
  • Integrated Horizon fee_stats for dynamic fee estimation
  • Ensured all XDR builders use estimated fees
  • Added support for fee bump transactions
  • Implemented retry logic for fee-related failures

New File

  • src/stellar/transaction-builder.service.ts

Updated Files

  • src/stellar/stellar.service.ts
  • All services responsible for building XDR transactions

Acceptance Criteria

  • Fee estimation is fetched from Horizon fee_stats
  • All XDR transactions use estimated fees
  • Fee bump transactions are supported
  • Insufficient fee errors trigger automatic retry
  • Project builds successfully with npm run build

Mandatory Checks

  • npm run build passes
  • No use of any types
  • Proper error handling for fee-related failures
  • PR references the related issue

Closes #25

@EmeditWeb

Copy link
Copy Markdown
Member

fix CI issues

@dubemoyibe-star

Copy link
Copy Markdown
Author

@EmeditWeb
on it

@EmeditWeb

Copy link
Copy Markdown
Member

fix CI issues and mc_

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

core: implement XDR transaction builder with fee estimation

2 participants