Repository navigation
fix(my-tickets): show the transfer result — recipient notice + fade-out (#266) - #345
Merged
presidojay1 merged 2 commits intoOct 16, 2026
Conversation
…StellarTickets#266) After a transfer the notice only echoed the typed email and the ticket just vanished on refresh. The notice now names the ticket (event + seat) and the recipient (name and email), says it left the list, and is a polite live region; the ticket fades out for 300ms before the list refreshes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ecipient (StellarTickets#266) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
❌ Deploy Preview for stellartickets failed.
|
|
@boluwacodes Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
After transferring a ticket, the list refreshed and the ticket simply vanished. The only feedback was a plain
Ticket transferred to <typed email>.line, which didn't say which ticket moved or name the recipient, wasn't announced to screen readers, and disappeared along with the ticket in a jarring jump.Changes
src/app/my-tickets/page.tsx/users/lookup(name, plus email when available).<li>getsopacity-0with atransition-opacity duration-300, and the list refreshes once the 300ms fade finishes, so the ticket visibly leaves instead of disappearing.role="status" aria-live="polite", so screen readers hear the result.New
src/lib/transfer-notice.tstransferNotice(ticket, recipient, email)builds the message. It lives outsidepage.tsxbecause Next.js only allows page-specific exports there. It falls back to the email when there's no name, and to "Ticket" when the event isn't loaded.Testing
my-tickets/page.test.tsx: after confirming a transfer, the ticket row hasopacity-0, and after the fade the status region reads "Gig · Seat A1 transferred to Bob (bob@example.com). It's no longer in your tickets." witharia-live="polite"vitest run src/app/my-tickets: 4/4 passed, including the existing transfer, resale and cancel teststsc --noEmitandeslintare clean for the touched filesCloses #266
Closes #267
Closes #268
Closes #269