Repository navigation
fix: announce form errors to assistive technology - #160
Open
efegokdemir wants to merge 2 commits into
Open
efegokdemir wants to merge 2 commits into
efegokdemir wants to merge 2 commits into
Conversation
❌ Deploy Preview for stellartickets failed.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make form submission errors discoverable to screen readers and associate the authentication form fields with their error message.
Changes
FormErroras an assertive alert with a stable, reusableid.aria-describedbywhen an error is present.aria-invalidwhile the form error is shown.Testing
git diff --check— passed.npm ci— local dependency installation stalled before completing, so no local test pass is claimed.Notes
The existing visual styling and error text are unchanged. Other pages continue using
FormErrorand automatically gain the alert semantics without changing their behavior.Fixes #142