Repository navigation
Conversation
Adds the computed NAV of an invoice against its current market price, so an investor can see whether the market is paying a premium or a discount. - lib/nav.ts: the pricing rules as pure helpers — where the price sits relative to NAV, the gap in basis points, and when a NAV is stale. - lib/api: fetchInvoiceNav reads GET /invoices/:id/nav and normalises the field spellings the endpoint has shipped. A 404 is "no NAV", not an error, so an unpriced invoice hides the chip instead of failing. - NavChip on the marketplace card and list row, and InvoiceNavPanel in the invest panel on the invoice detail page. - The chip and panel render nothing when an invoice has no NAV, and warn once the NAV is more than an hour old. Also fixes a pre-existing type error in FeeTierDisplay that was failing `tsc --noEmit` on dev, and with it the last merged CI run. Fixes StellarState#546
|
@flashdeed05-ai Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the computed NAV of an invoice against its current market price, so an investor can see whether the market is paying a premium or a discount.
Also fixes a pre-existing type error in FeeTierDisplay that was failing
tsc --noEmiton dev, and with it the last merged CI run.Close #546
Close #548
Close #550
Close #549
Description
Closes #
Type of Change
Checklist
Testing
How to Test
Test Coverage
Screenshots (if applicable)
Additional Notes
For Reviewers