Repository navigation
feat(invoices): add NAV fair value indicator (#546) - #559
Closed
flashdeed05-ai wants to merge 1 commit into
Closed
flashdeed05-ai wants to merge 1 commit into
flashdeed05-ai wants to merge 1 commit into
Conversation
Adds the computed NAV of an invoice against its current market price, so an investor can see whether the market is paying a premium or a discount. - lib/nav.ts: the pricing rules as pure helpers — where the price sits relative to NAV, the gap in basis points, and when a NAV is stale. - lib/api: fetchInvoiceNav reads GET /invoices/:id/nav and normalises the field spellings the endpoint has shipped. A 404 is "no NAV", not an error, so an unpriced invoice hides the chip instead of failing. - NavChip on the marketplace card and list row, and InvoiceNavPanel in the invest panel on the invoice detail page. - The chip and panel render nothing when an invoice has no NAV, and warn once the NAV is more than an hour old. Also fixes a pre-existing type error in FeeTierDisplay that was failing `tsc --noEmit` on dev, and with it the last merged CI run. Fixes StellarState#546
|
@flashdeed05-ai Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
Superseded by a PR opened from the johnsmccain fork — GitHub held this run for first-time-contributor approval, so CI never executed. Same branch, same commits. |
Author
|
Superseded by #560, opened from the johnsmccain fork. GitHub held this run for first-time-contributor approval, so CI never executed on this branch. Same commits, same branch name. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Shows the computed NAV (fair value) of an invoice against its current market price, so an investor can see at a glance whether the market is paying a premium or a discount.
Closes #546.
Scope
lib/nav.ts— the pricing rules as pure, testable helpers: where the price sits relative to NAV (above/at/below), the gap in basis points, when a NAV is stale, and how a per-fraction price is formatted.lib/api—fetchInvoiceNavreadsGET /invoices/:id/navand normalises the field spellings the endpoint has shipped (nav_per_fraction/navPerFraction/fair_value, and so on). A 404 means "this invoice has no NAV", which is not an error: it resolves tonullso an unpriced invoice hides the chip rather than failing.hooks/useInvoiceNav.ts— the query hook. Polling is suspended while the tab is hidden, and stops entirely for invoices the backend has no NAV for, so an unpriced invoice is not re-requested every minute.components/marketplace/NavChip.tsx— the chip, on the marketplace grid card and on the list row.components/invoices/InvoiceNavPanel.tsx— the NAV, current price and premium/discount figures in the invest panel on the invoice detail page.Acceptance criteria
Notes
computed_atis not treated as stale. There is nothing to compare it against, and warning on every invoice whose payload omits the field would be noise. The staleness warning therefore needs a real timestamp to fire.fraction_pricewhen the endpoint reports no market price of its own, so an open invoice with no secondary market still has something to compare.Also included
components/invoices/FeeTierDisplay.tsxhad a pre-existing type error (discountedFeeAmountpossibly null) that was failingtsc --noEmitondev— and with it the CI run for the last merge, #553. It is a one-line guard addition, included here so this PR can go green.Verification
npx tsc --noEmit— cleannpm run lint— clean (only pre-existing warnings in unrelated files)npm run build— succeedsnpm test— 1460 passed / 190 files, including 30 new tests acrosslib/__tests__/nav.test.ts,components/marketplace/__tests__/NavChip.test.tsx,components/invoices/__tests__/InvoiceNavPanel.test.tsxandapp/marketplace/__tests__/marketplace-nav-chip.test.tsx