Skip to content

fix(invoices): remove unused publish stub - #722

Merged
TS-mfon merged 3 commits into
StellarState:mainfrom
emynogithub:fix/issue-625-settlement-worker
Oct 28, 2026
Merged

TS-mfon merged 3 commits into
StellarState:mainfrom
emynogithub:fix/issue-625-settlement-worker

Conversation

@emynogithub

Copy link
Copy Markdown
Contributor

Summary

  • Remove the unreferenced publish stub that returned success without publishing.
  • Keep invoice publishing on the existing POST /invoices/:id/publish route, which delegates to the controller and service, checks ownership, and returns the published invoice DTO.

Closes #625

@drips-wave

drips-wave Bot commented Oct 22, 2026

Copy link
Copy Markdown

@emynogithub Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@TS-mfon

TS-mfon commented Oct 22, 2026

Copy link
Copy Markdown
Contributor

✅ PR Ready for Review

Due to a recent malware incident affecting our repositories, all PRs are required to pass automated security checks before being reviewed for merging.

This PR has passed all automated checks:

  • ✅ Security scan — no malicious code detected
  • ✅ No merge conflicts

A maintainer will review and merge this PR shortly.

@TS-mfon

TS-mfon commented Oct 26, 2026

Copy link
Copy Markdown
Contributor

✅ PR Ready for Review

Due to a recent malware incident affecting our repositories, all PRs are required to pass automated security checks before being reviewed for merging.

This PR has passed all automated checks:

  • ✅ Security scan — no malicious code detected
  • ✅ No merge conflicts

A maintainer will review and merge this PR shortly.

@TS-mfon
TS-mfon merged commit 28808c9 into StellarState:main Oct 28, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants