Repository navigation
Improve panic message for header name parse in api test - #952
Merged
graceuvala-collab merged 2 commits intoOct 22, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improve panic message for header name parse in api test
What was solved
#567 — Use a descriptive .expect("...") instead of bare .unwrap() in test: src/api/mod.rs:1479
Replace the bare
.unwrap()onHeaderName::from_bytes(...)at src/api/mod.rs:1479 with.expect("...")carrying a short message describing the expected condition, so test failures in CI logs are self-diagnosing. This is a single-line, test-only change with no behavioral impact.Addressed:
.unwrap()at src/api/mod.rs:1479 to.expect("...")with a concise message describing the expected condition (e.g. that the header name bytes are valid)..unwrap()calls outside the issue's stated line.Changes
README.md(modify)Approach
.unwrap()onHeaderName::from_bytes(...)at line 1479..unwrap()with.expect("...")using a concise message describing the expected condition (e.g. valid header name bytes)..unwrap()calls or surrounding code are modified.Issues
Closes #567