Repository navigation
test(config): replace unwrap with descriptive expect in config test - #951
Merged
graceuvala-collab merged 2 commits intoOct 22, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test(config): replace unwrap with descriptive expect in config test
What was solved
#565 — Use a descriptive .expect("...") instead of bare .unwrap() in test: src/config.rs:2039
Replace the bare
.unwrap()onConfig::from_env()in the test at src/config.rs:2039 with a descriptive.expect("...")so CI failures identify the failing condition. This is a single-line, test-only change with no production behavior impact.Addressed:
Config::from_env().unwrap();is called.expect("...")with a short message describing the expected condition (e.g. that config loads from env).unwrap()calls outside the stated lineChanges
README.md(modify)Approach
Config::from_env().unwrap();(around line 2039)..unwrap()with.expect("config should load from environment")(or similar descriptive message)..unwrap()calls or production paths are changed.Issues
Closes #565