Repository navigation
test: add cross-platform and endianness tests - #142
Merged
Ayinkx01 merged 1 commit intoOct 28, 2026
Merged
Conversation
Pin XDR big-endian encoding with explicit byte sequences, assert path separator and current-directory normalization, and require byte-identical inspect-wasm output for native, forward-slash, and parent-directory paths. Document the cross-platform test strategy in the testing guide. Closes StellarFoundry#91
Ayinkx01
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds explicit cross-platform and endianness coverage.
crates/devkit-xdr/tests/endianness.rspins XDR's big-endian wire format with explicit byte arrays forScVal::U32,ScVal::I32, andScVal::I64, round-trips them, and asserts host-independent base64/JSON output.crates/devkit-core/tests/cross_platform.rsasserts that native and forward-slash paths produce identical components, that interior.components are removed, and that parsers accept CRLF input.crates/devkit-cli/tests/path_normalization.rsrunsinspect-wasmwith a native path, a forward-slash path, and a path containing.., requiring byte-identical JSON output.docs/TESTING.mdandCHANGELOG.md.Verification
All pass locally (Windows). The added tests use explicit bytes and path components, so they are also valid on the Linux and macOS CI runners.
Closes #91