Repository navigation
fix: reject rollback when match is in PendingResult or Completed state - #1877
Merged
famvilianity-eng merged 1 commit intoOct 23, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR ensures that
dispute_and_rollback_matchrejects attempts to trigger a rollback vote once a match result has already been submitted by the oracle (i.e. when the match state isMatchState::PendingResultorMatchState::Completed).Changes
contracts/escrow/src/lib.rs(dispute_and_rollback_match), added explicit validation to reject rollback withError::InvalidStateifmatch.state == MatchState::PendingResult || match.state == MatchState::Completed.contracts/escrow/src/tests/dispute_rollback.rs, added regression unit testtest_rollback_rejects_pending_result_matchverifying that attempting to rollback a match inPendingResultreturnsErr(Ok(Error::InvalidState)).Closes #1817