Feat/issue 196 claimable balance fallback#249
Merged
Kingsman-99 merged 4 commits intoJun 25, 2026
Merged
Conversation
…lar-split#195) Introduces Sep41Adapter, a thin normalisation layer over Soroban token contracts that may or may not implement the full SEP-41 spec. Lazy capability probing (same FunctionNotFound pattern as featureDetection) gates allowance/approve calls and returns null with a console.warn for unsupported methods. Exports wired into src/index.ts. Unit tests cover full SEP-41, transfer-only, and missing-method token shapes. Closes Stellar-split#195 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Stellar-split#198) Introduces HorizonFallbackReader (src/horizonFallback.ts) that wraps Horizon.Server and normalises getAccount / getAccountBalances responses into SDK-wide NormalizedAccount and NormalizedBalance shapes. StellarSplitClientConfig gains an optional horizonUrl field. When set, the client creates a HorizonFallbackReader and wires the two new public methods (getAccount, getAccountBalances) through a FallbackChain so that a failing Soroban RPC getAccount call automatically retries against Horizon. Write paths are unaffected and continue to require a live Soroban RPC endpoint. NormalizedAccount and NormalizedBalance are exported from src/index.ts. 11 unit/integration tests cover: normalised shapes, RPC-healthy path, RPC-failure → Horizon fallback, missing-horizonUrl error paths. Closes Stellar-split#198 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Stellar-split#197) Introduces buildSponsoredOnboarding (src/sponsorship.ts) which wraps caller-provided operations between beginSponsoringFutureReserves and endSponsoringFutureReserves so that a brand-new payer account can fund an invoice without first acquiring XLM. Operation ordering enforced: begin (source=sponsor) → inner ops → end (source=newAccount). Both accounts must co-sign the returned unsigned transaction before submission. When config.horizonUrl is set the function fetches the sponsor's live XLM balance via Horizon.Server.loadAccount and verifies that the available balance covers the sponsor's own minimum (1 XLM) plus one base reserve (0.5 XLM) per wrapped operation. Two typed errors are exported: MissingSponsorAccountError (config.sponsorAccount absent) and InsufficientReserveError (balance too low, exposing availableStroops and requiredStroops). StellarSplitClientConfig gains sponsorAccount?: string. buildSponsoredOnboarding, MissingSponsorAccountError, and InsufficientReserveError are exported from src/index.ts. 11 unit tests cover op ordering, missing config, insufficient balance, balance check skip, and reserve math scaling with op count. Closes Stellar-split#197 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…irmed refunds (Stellar-split#196) Introduces src/claimableBalanceFallback.ts with three exports: isRefundTransferError(error) — returns true when a Soroban error message indicates a failed token transfer due to a missing account or missing trustline (op_no_trust, op_no_destination, AccountMissing, TrustNotFound, etc.). createClaimableRefund(payer, amount, asset, sourceAddress, config) — builds and submits a classic Stellar createClaimableBalance operation via Horizon.Server, making the refund claimable by payer at any time. Extracts the balance_id from the created operation record; falls back to a synthetic ID prefixed with zeros when the operations endpoint is unavailable. Emits a distinguishable [StellarSplitClient] claimable-refund fallback log entry. getClaimableRefunds(payer, config) — queries Horizon claimableBalances for all pending balances claimable by payer. StellarSplitClient gains two public methods: refundInvoice(invoiceId, creator, payerAddress?) — calls refund_invoice on the contract; on trustline/account errors with horizonUrl configured, automatically retries via createClaimableRefund, emits a console.warn, and returns { fallback: true, balanceId, txHash }. Normal path returns { fallback: false, txHash }. getClaimableRefunds(payer) — delegates to the module function above. StellarSplitClientConfig is unchanged (horizonUrl added in Stellar-split#198 is reused). All exports wired into src/index.ts. 21 unit + integration tests cover: trustline error detection (8 patterns), successful submission, correct amount string (stroops→decimal), synthetic balance ID fallback, missing horizonUrl throws, empty/multi-entry listing, normal refund path, fallback trigger, no-horizonUrl rethrow. Closes Stellar-split#196 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
@Atisan12 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #196