Feat: redstone signal optimization - #311
Open
chocodev11 wants to merge 7 commits into
Open
Conversation
chocodev11
changed the title
chocodev11
marked this pull request as draft
August 3, 2026 06:28
coco875
reviewed
Aug 3, 2026
| @@ -49,37 +48,158 @@ impl DefaultRedstoneWireEvaluator { | |||
| } | |||
|
|
|||
| fn calculate_target_strength(&self, level: &dyn LevelReader, pos: BlockPos) -> i32 { | |||
Contributor
There was a problem hiding this comment.
hmm the function look very long, I check on lithium are function are more well organize
chocodev11
marked this pull request as ready for review
August 4, 2026 14:11
|
This pull request has conflicts with the base branch "master". Please resolve those so we can test out your changes. |
|
Conflicts have been resolved! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR purpose is porting 2 optimization concept i saw in lithium for redstone and it should be preserve vanilla behaviour, may test with flint idk.