Implement shulker box

[Alvsch]

Implements the shulker box block and block entity.

Known issues

• Starting of shulker box animations is not yet implemented

Other changes

• Added fn apply_components_from_item to BlockEntity trait
• Added Option<BlockEntity> to BlockLootContext
• Added fn contract to Aabb<DVec3, World> matching the vanilla equivelant
• Added fn prevents_block_drops to Player which returns instabreak ability
• Added fn to_nbt_tag_ref to LockCode
• Fix ordering issue where BlockEntity was retrieved after its removal

Looking for feedback on overall implementation design as I fix the current issues

[Alvsch]

I'm wondering if the current known issues should be fixed in another PR as this behavior is consistently missing across all container implementations.

[JunkyDeveloper]

which issues do you mean?

[Alvsch]

Animations doesn't work/isn't implemented (same with barrels). Looking into it is not so hard to implement.

trait Container needs start_open and stop_open functions to be added

[JunkyDeveloper]

as a maintainer I would like to have it seperated into another PR, so it is easier to review and you can merge that branch already here.

I personally would also have the breaking changes in another PR, because the ice block impl was adding there some things and it took some time to figure that out while reviewing the ice block in general.

Because you can give also a more detailed description why is that needed, which would made the search way easier :)

But that is not a requirement, but a feedback from my side, maybe the other maintainer see it different :)

[DarkMrMelther]

I think 4lve said that in his chest pr the counter of players with the container open was implemented

[Alvsch]

I think 4lve said that in his chest pr the counter of players with the container open was implemented

If you're talking about the basic_containers branch, that was closed due to scope creep iirc. This branch is however based on master after CuzImClicks Menu API changes was merged.

@JunkyDeveloper I've update the description to include all the changes that touches other parts than shulker boxes for me and anyone to look at. If the general consensus is to create a new PR for those changes I could do that.

[JunkyDeveloper]

@JunkyDeveloper I've update the description to include all the changes that touches other parts than shulker boxes for me and anyone to look at. If the general consensus is to create a new PR for those changes I could do that.

Thanks, will not have time in the next 10 days. but I think it will also help other maintainers :) at first we need to internally discuss all the things who we want to have it, but for now that is more than fine!