Skip to content

Feat: organizing entitie - #287

Open
chocodev11 wants to merge 22 commits into
Steel-Foundation:masterfrom
chocodev11:mob
Open

Feat: organizing entitie#287
chocodev11 wants to merge 22 commits into
Steel-Foundation:masterfrom
chocodev11:mob

Conversation

@chocodev11

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions

Copy link
Copy Markdown

This pull request has conflicts with the base branch "master". Please resolve those so we can test out your changes.

@github-actions

Copy link
Copy Markdown

Conflicts have been resolved! 🎉

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm end_crystal I would put in the same categorie of tnt, so maybe explosion like fireball, and reserve boss for guardian, ender dragon, wither, (forget the name of the blue mob)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't put it in item but don't know what other categorie to fit

@@ -0,0 +1 @@
//! Neutral entity implementations.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe give some example ? to help contributor help place their entity in the correct category

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

which angry only if you hit them first

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I mean add it in the comment to make it more clear)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

they have to know huh, like every other? or i will add comments to every category?

@coco875 coco875 Jul 31, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it would be only to category that can be ambigious, so neutral and passive ?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wdym

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a small description of the categorie to neutral and passive (so neutral say that it only become agressif when hit and passive never get agressif)

@github-actions

github-actions Bot commented Aug 1, 2026

Copy link
Copy Markdown

This pull request has conflicts with the base branch "master". Please resolve those so we can test out your changes.

@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown

Conflicts have been resolved! 🎉

JunkyDeveloper
JunkyDeveloper previously approved these changes Aug 8, 2026

@JunkyDeveloper JunkyDeveloper left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok now with that order

@github-actions

github-actions Bot commented Aug 9, 2026

Copy link
Copy Markdown

This pull request has conflicts with the base branch "master". Please resolve those so we can test out your changes.

@github-actions

github-actions Bot commented Aug 9, 2026

Copy link
Copy Markdown

Conflicts have been resolved! 🎉

JunkyDeveloper
JunkyDeveloper previously approved these changes Aug 9, 2026
@JunkyDeveloper

Copy link
Copy Markdown
Contributor

fix lint

@coco875 coco875 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

look good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants