cleanup steel folder - #277
Open
coco875 wants to merge 17 commits into
Open
Conversation
4lve
reviewed
Jul 22, 2026
4lve
left a comment
4lve
left a comment
Collaborator
There was a problem hiding this comment.
Haven't looked at everything yet but the parts I've seen look good
Contributor
|
Lint is still failing :) |
Contributor
Author
|
now it work |
|
This pull request has conflicts with the base branch "master". Please resolve those so we can test out your changes. |
|
Conflicts have been resolved! 🎉 |
|
This pull request has conflicts with the base branch "master". Please resolve those so we can test out your changes. |
|
Conflicts have been resolved! 🎉 |
JunkyDeveloper
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have use rustqual to see what improvement he think and ask ai to resolve most of them then I manually check.
more info : https://github.com/SaschaOnTour/rustqual
I have manually revert som SRP and IOSP violation because he check a bit too much manually trying to split struct that was already doing only one thing (like the CommandLogger) or complain because there is one if in a function where it was instruction. Outside of that he also suggest some very minor performance improvement (re-use allocation, avoid clone, etc) and IOSP that was useful to make the code more clear and function less long.
there is still a part where I have doubt it's in main.rs where it change output to result.