Skip to content

feat: Implement Enderchest - #254

Draft
shdctx wants to merge 11 commits into
Steel-Foundation:masterfrom
shdctx:feat-impl-Enderchest
Draft

feat: Implement Enderchest#254
shdctx wants to merge 11 commits into
Steel-Foundation:masterfrom
shdctx:feat-impl-Enderchest

Conversation

@shdctx

@shdctx shdctx commented Jul 13, 2026

Copy link
Copy Markdown

basic Enderchest functions are implemented.

  • the inventory is saved in the player data so the EC works more like a "portal"
    aka a Player bound Container

Video of my tests:
https://workupload.com/file/Jg378VjgktD

What is still missing:

  • Sound effects & Opening animation

  • Piglin Agro

@github-actions

Copy link
Copy Markdown

This pull request has conflicts with the base branch "master". Please resolve those so we can test out your changes.

@github-actions

Copy link
Copy Markdown

Conflicts have been resolved! 🎉

@4lve

4lve commented Jul 15, 2026

Copy link
Copy Markdown
Collaborator

There is a pending inventory refactor by CuzImClicks. Will wait until that is merged

@github-actions

Copy link
Copy Markdown

This pull request has conflicts with the base branch "master". Please resolve those so we can test out your changes.

@github-actions

Copy link
Copy Markdown

Conflicts have been resolved! 🎉

@coco875 coco875 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look mostly good, I guess that now that the container refactor are merge 4lve (or other trial maintener) can also do a review

Comment on lines +257 to +262
// Register ender chest block entity factory
registry.register(
&vanilla_block_entity_types::ENDER_CHEST,
|level, pos, state| Arc::new(EnderChestBlockEntity::new(level, pos, state)),
);

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only a quick comment for me, make that better, because this is shit

@shdctx
shdctx marked this pull request as draft August 5, 2026 16:05
@github-actions

Copy link
Copy Markdown

This pull request has conflicts with the base branch "master". Please resolve those so we can test out your changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants