Repository navigation
[perf] 얼굴 인식 세션 후보를 쿼리에서 출석 대상으로 거르기 - #248
Merged
Merged
Conversation
minwoo-3
requested review from
Fresh-Banana,
Ims2oha and
kimseongchan0914
as code owners
October 12, 2026 23:10
Fresh-Banana
approved these changes
Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ 작업 내용
FaceTemplateRepository에 출석 대상 템플릿만 읽는 쿼리 2개 추가 (studentfetch join)findAllEligible(): 세션 생성용, 학생 id 순findAllEligibleByStudentIdIn(ids): AI 세션 재생성용datagsm_student_id > 0FaceRecognitionService의eligibleTemplates()·candidateTemplates()가 새 쿼리를 쓰고, Java에서 거르던eligibleStudent()삭제findAllByOrderByStudent_IdAsc()·findAllByStudent_IdIn()삭제🔍 리뷰 시 참고사항
Student.isAttendanceEligible()과 쿼리 두 곳에 나뉩니다. 쿼리 JavaDoc에 연결을 적었고,FaceTemplateRepositoryTest에서 쿼리 결과와isAttendanceEligible()판단이 같은지 비교합니다.maxCandidates) 검사는 그대로 거른 뒤 개수 기준입니다.FaceRecognitionServiceTest20개 통과(FACE_NO_ENROLLED_STUDENTS테스트 추가,FACE_TOO_MANY_CANDIDATES기존 테스트 통과).FaceTemplateRepositoryTest(동의 없음·얼굴 동의만 없음·개인정보 동의만 없음·호실 없음·DataGSM id 없음 학생 제외 확인)는 로컬에 PostgreSQL이 없어 실행하지 못했습니다. CI 결과로 확인합니다. 전체./gradlew build도 같은 이유로 로컬에서 돌리지 않았습니다.✅ 체크리스트
.env.example등) 변경이 필요한 경우 작성 또는 수정했나요?📎 관련 이슈(선택)