Repository navigation
[feat] DataGSM 학생 제외 목록 - #243
Merged
Merged
Conversation
minwoo-3
requested review from
Fresh-Banana,
Ims2oha and
kimseongchan0914
as code owners
October 10, 2026 14:59
Ims2oha
approved these changes
Oct 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ 작업 내용
StudentExclusionProperties:CHECKUP_EXCLUDED_DATAGSM_STUDENT_IDS(쉼표 구분)를checkup.student.excluded-datagsm-ids로 읽습니다. 설정이 없으면 빈 목록입니다.StudentSyncService.syncAll, 웹훅·수동 동기화 공통): 제외 학생은 조회 전에 걸러서 새로 저장하지도 갱신하지도 않습니다.AuthService): 제외 학생 계정은UNSUPPORTED_ACCOUNT(403)로 거부하고 회원·학생을 만들지 않습니다. 관리자 허용 목록에 있어도 거부합니다.compose.prod.yaml,.env.example에 변수를 추가했습니다.🔍 리뷰 시 참고사항
AdminProperties)과 같은 구조입니다.배포 뒤 운영에서 할 일
.env에CHECKUP_EXCLUDED_DATAGSM_STUDENT_IDS=<사감선생님 student_id>를 넣고 재배포합니다.ON DELETE CASCADE로 같이 지워집니다.실행한 검사
StudentExclusionPropertiesTest(2),StudentSyncServiceTest(13),WebhookServiceTest(22),AuthServiceTest(23) 통과./gradlew build: 599개 중 134개 실패. 실패한 테스트는 모두 로컬 Postgres(localhost:5433)·Redis에 연결하지 못한 것입니다. CI에서 확인합니다.✅ 체크리스트
.env.example등) 변경이 필요한 경우 작성 또는 수정했나요?📎 관련 이슈(선택)