Repository navigation
ci: install the nnnotes release named in .github/nnnotes.txt - #24
Merged
Merged
Conversation
The publishing workflows install nnnotes from PyPI, the release that .github/nnnotes.txt names with its extras deck and fonts, instead of building the checkout and its Rust extension. - A music data build's inputs name the installed nnnotes version (nnnotesVersion) and the ournotes-deck commit of the installed ournotes-sim release; the engines are downloaded from that release, and the schema gate uses the schema the installed nnnotes ships. - The plan job installs nnnotes and needs no git history; the build job installs it before the JP network check, which imports it. - CI tests the publishing scripts in their own job, with the release they install. - MUSIC_DATA.md and STORY_SITE.md describe raising the pinned release. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The scheduled music-data workflow builds and publishes each region's chart statistics itself, with the native statistics cache and the installed deck model release. The separate workflow that published an externally built bundle, its upload and download helpers and their tests are removed. The songs page workflow keeps the page smoke test and page assembly scripts it shares (prebuilt_publish_smoke.mjs, prebuilt_publish_page.py). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
nnnotes 0.2.1 pins the deck model of ournotes-deck 0.0.8, which measures a chart on its own notes when its score row's full combo count differs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
nichinichisou0609
marked this pull request as ready for review
October 13, 2026 18:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The publishing workflows install nnnotes from PyPI (
.github/nnnotes.txt:nnnotes[deck,fonts]==0.2.1) instead of building the checkout and its Rust extension.music_data.py: a build's inputs namennnotesVersion(the installed nnnotes) anddeckCommit(the installedournotes-simrelease); the engines come from that release; the schema gate usesnnnotes.schemas.load("music-data"). No git history,rust/Cargo.lockorsrc/reads remain.music-data-region.yml: noPYTHONPATH: src; the plan job installs nnnotes (nofetch-depth: 0); the build job installs it before the JP network check, which imports it.story-site-region.yml: installs the same release; no Rust cache.ci.yml: aworkflowsjob runs the songs page smoke and.github/scriptstests with the pinned release.MUSIC_DATA.md,STORY_SITE.md: raising.github/nnnotes.txtreplaces syncing the fork.music-data-prebuilt.yml,prebuilt_publish.py,prebuilt_publish_download.pyand their tests are removed: the scheduledmusic-data.ymlbuilds and publishes each region itself with the native statistics cache.songs-page.ymlkeeps the scripts it shares (prebuilt_publish_smoke.mjs,prebuilt_publish_page.py).The first run after this change rebuilds, since the inputs now carry
nnnotesVersion.Locally the
.github/scriptstests pass (330) withnnnotes[deck,fonts]==0.2.1installed from PyPI (deck model ournotes-deck 0.0.8).Dry run (run 38433788453,
force, both regions), compared with the published files:provenance.deck(0.0.8),provenance.exporter.version(0.2.1) and the replay engines differ.build.jsoninputs namennnotesVersion: 0.2.1and thedeckCommitof ournotes-deck 0.0.8.