Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/scripts/prebuilt_publish_page.py
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,9 @@ def main():
if subprocess.check_output(["git", "-C", str(root), "status", "--porcelain", "--untracked-files=all", "--", relative_page], text=True).strip():
p.error("page files are dirty")
files = sorted(a.page.iterdir())
expected = {"index.html", "catalog.js", "ranking.js", "pareto.js", "songs.js", "text.js", "replay-panel.js", "replay-worker.js", "replay-preset.js"}
expected = {"index.html", "catalog.js", "expectation.js", "ranking.js", "pareto.js", "songs.js", "text.js", "replay-panel.js", "replay-worker.js", "replay-preset.js"}
if {v.name for v in files} != expected or any(not v.is_file() or v.is_symlink() for v in files):
p.error("pinned songs module closure is not the reviewed nine files")
p.error("pinned songs module closure is not the reviewed ten files")
spec = importlib.util.spec_from_file_location("music_data", a.publisher)
module = importlib.util.module_from_spec(spec)
sys.modules[spec.name] = module
Expand Down
2 changes: 1 addition & 1 deletion .github/scripts/prebuilt_publish_smoke.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import { execFileSync } from "node:child_process";

const [page, out] = process.argv.slice(2);
if (!page || !out) throw new Error("usage: prebuilt_publish_smoke.mjs <examples/songs> <out>");
for (const filename of ["replay-panel.js", "replay-worker.js", "replay-preset.js", "text.js", "catalog.js", "ranking.js"]) {
for (const filename of ["replay-panel.js", "replay-worker.js", "replay-preset.js", "text.js", "catalog.js", "expectation.js", "ranking.js"]) {
await fs.access(path.join(page, filename));
execFileSync(process.execPath, ["--check", path.join(page, filename)], { stdio: "pipe" });
}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/music-data-prebuilt.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ permissions:
contents: write

concurrency:
# Both regions and songs-page.yml publish the same nine-file songs/ closure.
# Both regions and songs-page.yml publish the same ten-file songs/ closure.
group: songs-page-publication
cancel-in-progress: false

Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/songs-page.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ on:
type: string
required: true
dry_run:
description: Validate the new UI and list nine uploads without writing objects
description: Validate the new UI and list ten uploads without writing objects
type: boolean
default: true

Expand Down Expand Up @@ -62,7 +62,7 @@ jobs:
run: |
node publisher/.github/scripts/prebuilt_publish_smoke.mjs \
"$GITHUB_WORKSPACE/player/examples/songs" "$WORK/data"
- name: Validate the clean nine-file closure without credentials
- name: Validate the clean ten-file closure without credentials
run: |
python publisher/.github/scripts/prebuilt_publish_page.py \
--publisher "$GITHUB_WORKSPACE/publisher/.github/scripts/music_data.py" \
Expand Down
Loading