Skip to content

Rewrap the copyright header under 100 columns - #760

Merged
alexander-yevsyukov merged 2 commits into
masterfrom
improve-c-header-wrapping
Sep 7, 2026
Merged

alexander-yevsyukov merged 2 commits into
masterfrom
improve-c-header-wrapping

Conversation

@alexander-yevsyukov

Copy link
Copy Markdown
Contributor

What changed

The copyright notice in .idea/copyright/CodeMatters_Open_Source.xml is rewrapped, and every file header in the repository is re-stamped from it.

Two commits, so the mechanical churn stays separate from the decision:

  1. Rewrap the notice — one line changes in the copyright profile.
  2. Re-stamp file headers — 261 files, six header lines each.

Why

The project right margin is 100 columns, declared in .idea/codeStyles/Project.xml. XML files prefix each header line with ~, which pushed the longest notice lines to 101 columns. The notice is now wrapped so the widest rendered line is 97 columns in XML, 96 in block comments, and 95 in hash comments.

Notes for the reviewer

  • Commit 2 is generated output. The update-copyright skill rebuilds each header from the profile named in .idea/copyright/profiles_settings.xml, so the diff is uniform: exactly six changed lines per file, all inside the leading comment block, no hunk starting past line 20.
  • .gitignore was stamped by hand. The script selects files by extension, so an extensionless file never enters its scope even though it carries a hash-style header.
  • The notice wording is unchanged. Only line breaks moved, which the documentation reviewer verified by flattening both versions and diffing them.
  • migrate distributes .idea/copyright/ into consumer repositories, preserving only profiles_settings.xml. Consumers pick up the new profile on their next ./config/pull, and their headers stay on the old wrapping until each runs the update-copyright skill.

Verification

  • ./gradlew :buildSrc:test detekt passes. The root project registers no build or dokkaGenerate task, so neither was run.
  • Reviewers spine-code-review, kotlin-engineer, review-docs, and dependency-audit all returned APPROVE with no findings.
  • The version gate does not apply, since this repository has no root version.gradle.kts.

🤖 Generated with Claude Code

alexander-yevsyukov and others added 2 commits September 7, 2026 17:55
The notice lines were long enough that the XML comment prefix (`  ~ `)
pushed a header line past the project's 100-column right margin declared
in `.idea/codeStyles/Project.xml`.

Rewrap the licence paragraphs so the widest line is 97 columns once the
XML prefix is applied, and 96 in block comments. Also restore the file's
trailing newline.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Apply the rewrapped notice to every source file that carries a copyright
header, so the headers match the IDEA copyright profile again.

Generated by the `update-copyright` skill, which rebuilds each header
from the profile named in `.idea/copyright/profiles_settings.xml`. The
script selects files by extension, so `.gitignore` carries the same
header applied by hand.

Comment text only: every file changes exactly six header lines, and no
line outside the header block is touched.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 7, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-07T17:03:55.444766Z 136062c PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@alexander-yevsyukov alexander-yevsyukov moved this to 🏗 In progress in v2.0 Sep 7, 2026
@alexander-yevsyukov alexander-yevsyukov self-assigned this Sep 7, 2026
@alexander-yevsyukov alexander-yevsyukov moved this from 🏗 In progress to In Review in v2.0 Sep 7, 2026
@alexander-yevsyukov

Copy link
Copy Markdown
Contributor Author

@armiol, the main reason is the wrapping caused by agent reviews in .vue files. We want to avoid the numerous review/updates for .vue and other popular XMLs.

@alexander-yevsyukov
alexander-yevsyukov merged commit 598cb4b into master Sep 7, 2026
2 checks passed
@alexander-yevsyukov
alexander-yevsyukov deleted the improve-c-header-wrapping branch September 7, 2026 17:30
@github-project-automation github-project-automation Bot moved this from In Review to ✅ Done in v2.0 Sep 7, 2026
@alexander-yevsyukov alexander-yevsyukov moved this from ✅ Done to In Review in v2.0 Sep 7, 2026
@alexander-yevsyukov alexander-yevsyukov moved this from In Review to ✅ Done in v2.0 Sep 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

2 participants