Skip to content

Refine kotlin-engineer and related skills - #676

Closed
alexander-yevsyukov wants to merge 7 commits into
masterfrom
more-skills
Closed

alexander-yevsyukov wants to merge 7 commits into
masterfrom
more-skills

Conversation

@alexander-yevsyukov

@alexander-yevsyukov alexander-yevsyukov commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

This PR refines the definition of the kotlin-engineer skill and makes the related skills use its definitions when it comes to "understanding" Kotlin.

Other notable changes

  • The skill kotlin-review was renamed to spine-code-review, and adjusted accordingly.
  • The migrate script was updated to take are of the new and renamed skills.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the agent/skill taxonomy around Kotlin work by refining the kotlin-engineer skill (general Kotlin language/design standards) and renaming the repo-specific reviewer from kotlin-review to spine-code-review, then wiring the surrounding docs and tooling to the new split of responsibilities.

Changes:

  • Introduce spine-code-review (agent + skill) for repo-specific review rules, and retire kotlin-review.
  • Expand/clarify kotlin-engineer guidance and references, and make other skills point to it as the Kotlin baseline.
  • Update pre-pr dispatch docs and the migrate script to account for the new/renamed skills; minor Gradle buildSrc tweak to use SpinePublishing.NONE_PREFIX.

Reviewed changes

Copilot reviewed 23 out of 23 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
README.md Updates AI-agent config examples to reference spine-code-review / kotlin-engineer.
migrate Updates Hugo-only pruning to remove the new JVM-oriented skills/agents.
buildSrc/src/main/kotlin/uber-jar-module.gradle.kts Replaces magic "NONE" with SpinePublishing.NONE_PREFIX.
AGENTS.md Adds a direct pointer for Kotlin implementation work to kotlin-engineer.
.github/copilot-instructions.md Adds Kotlin-work guidance pointing to kotlin-engineer.
.claude/commands/review-docs.md Updates reviewer pointer from kotlin-reviewspine-code-review.
.claude/commands/pre-pr.md Updates reviewer dispatch guidance to run kotlin-engineer + spine-code-review in parallel.
.claude/agents/spine-code-review.md Adds the new Claude subagent wrapper for spine-code-review.
.claude/agents/review-docs.md Updates code-quality pointer from kotlin-reviewspine-code-review.
.claude/agents/kotlin-review.md Removes the old kotlin-review Claude subagent wrapper.
.claude/agents/kotlin-engineer.md Adds a Claude subagent wrapper for kotlin-engineer.
.agents/tasks/enforce-max-line-length.md Updates ownership references to spine-code-review (one stale line reference noted).
.agents/skills/spine-code-review/SKILL.md Renames and refocuses the repo-specific review skill; clarifies division of responsibility vs kotlin-engineer.
.agents/skills/spine-code-review/agents/openai.yaml Adds OpenAI agent metadata for spine-code-review.
.agents/skills/raise-coverage/SKILL.md Points test-writing baseline to kotlin-engineer.
.agents/skills/pre-pr/SKILL.md Dispatches kotlin-engineer + spine-code-review for code changes; updates aggregation labels.
.agents/skills/kotlin-review/agents/openai.yaml Removes OpenAI agent metadata for the retired kotlin-review.
.agents/skills/kotlin-engineer/SKILL.md Refines the Kotlin-engineering policy text and adds “when to use / fast path” guidance.
.agents/skills/kotlin-engineer/references/coroutines.md Re-formats the anti-patterns table (content preserved).
.agents/skills/kotlin-engineer/agents/openai.yaml Updates OpenAI agent metadata to match the refined kotlin-engineer scope.
.agents/skills/java-to-kotlin/SKILL.md States kotlin-engineer as the baseline for conversions.
.agents/skills/gradle-review/SKILL.md Updates “do not duplicate” references to the new review-skill split.
.agents/_TOC.md Updates TOC entries for kotlin-engineer and spine-code-review and removes kotlin-review.

Comment thread .agents/tasks/enforce-max-line-length.md
@alexander-yevsyukov
alexander-yevsyukov marked this pull request as ready for review June 1, 2026 20:12
@alexander-yevsyukov
alexander-yevsyukov marked this pull request as draft June 2, 2026 00:29
auto-merge was automatically disabled June 2, 2026 00:29

Pull request was converted to draft

@alexander-yevsyukov
alexander-yevsyukov removed the request for review from armiol June 2, 2026 00:30
@alexander-yevsyukov

Copy link
Copy Markdown
Contributor Author

Closing in favour of SpineEventEngine/agents#3.

@alexander-yevsyukov
alexander-yevsyukov deleted the more-skills branch June 4, 2026 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants