Skip to content

fix: add image - #111

Merged
lethanhdat762003 merged 1 commit into
devfrom
feat/implement-contact-sales
Jul 17, 2026
Merged

lethanhdat762003 merged 1 commit into
devfrom
feat/implement-contact-sales

Conversation

@lethanhdat762003

Copy link
Copy Markdown
Member

What?

Why?

How?

Testing?

  • Functional Testing
  • Security
  • Performance
  • Error Handling
  • Code Quality
  • Documentation
  • Database
  • Deployment
  • Final Review

Anything Else?

@lethanhdat762003
lethanhdat762003 merged commit 550a780 into dev Jul 17, 2026
1 check passed

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for an optional header image in the "Contact Sales" email template and updates the email context utility to fall back to email_context_data for the header_image_url. The review feedback suggests setting the image's alt attribute to empty (alt="") to avoid redundant announcements for screen readers, as the adjacent heading already contains the same text.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment on lines +3 to +7
{% if header_image_url %}
<div class="illustration">
<img src="{{ header_image_url }}" alt="New Subscription Request" />
</div>
{% endif %}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Since the <h1> heading immediately following this image already contains the text "New Subscription Request", having the same text as the alt attribute of the image is redundant for screen readers. According to accessibility best practices (WCAG), decorative header images or images whose meaning is already conveyed by adjacent text should have an empty alt attribute (alt="") to prevent screen readers from announcing the same information twice.

  {% if header_image_url %}
  <div class="illustration">
    <img src="{{ header_image_url }}" alt="" />
  </div>
  {% endif %}

@ngovinh2k2
ngovinh2k2 deleted the feat/implement-contact-sales branch August 18, 2026 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant