Repository navigation
fix: add image - #111
fix: add image#111
Conversation
There was a problem hiding this comment.
Code Review
This pull request adds support for an optional header image in the "Contact Sales" email template and updates the email context utility to fall back to email_context_data for the header_image_url. The review feedback suggests setting the image's alt attribute to empty (alt="") to avoid redundant announcements for screen readers, as the adjacent heading already contains the same text.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| {% if header_image_url %} | ||
| <div class="illustration"> | ||
| <img src="{{ header_image_url }}" alt="New Subscription Request" /> | ||
| </div> | ||
| {% endif %} |
There was a problem hiding this comment.
Since the <h1> heading immediately following this image already contains the text "New Subscription Request", having the same text as the alt attribute of the image is redundant for screen readers. According to accessibility best practices (WCAG), decorative header images or images whose meaning is already conveyed by adjacent text should have an empty alt attribute (alt="") to prevent screen readers from announcing the same information twice.
{% if header_image_url %}
<div class="illustration">
<img src="{{ header_image_url }}" alt="" />
</div>
{% endif %}
What?
Why?
How?
Testing?
Anything Else?