Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
closes #851
Adds the missing toast assertion to the copy test in
WalletScreen.test.tsx. This is a test-only change, with no production code touched.Context
The behavior #851 describes was already fixed in #829 (merge commit 5a11f40, Oct 1). On
maintoday:WalletScreen.tsxandAccountCard.tsxhave no localcopiedstate and no inline fixed-position toast markup.useToast()(success(...), which wrapsaddToast, anderror(...)inAccountCard).ToastRenderer/ToastContaineris mounted inApp.tsx.The one gap left is the issue's fourth acceptance criterion.
WalletScreen.test.tsxsets up asuccessToastmock but the copy test never asserts it.Changes
src/screens/WalletScreen.test.tsx: after triggering copy, assertsuccessToastis called once with"Address Copied"and the message"The address has been copied to your clipboard."No changes to
WalletScreen.tsx,AccountCard.tsxorToastContext.tsx. I deliberately did not rewritesuccess(...)asaddToast({ type: "success", ... }), sincesuccessis a thin wrapper and the behavior is identical.Acceptance criteria mapping
useToast()success/errorwrappers)ToastContainerhandles all toastsApp.tsx)AccountCard.test.tsxalready did)How to verify
npm test -- src/screens/WalletScreen.test.tsxsuccess(...)call from theonCopyhandler inWalletScreen.tsxand see the test fail.Testing
npm run lintnpm run typechecknpm run buildnpm run sizenpm run test:exportsnpm test(Tick each box only after seeing the command pass.)## Summary
Refs #851
Adds the missing toast assertion to the copy test in
WalletScreen.test.tsx. This is a test-only change, with no production code touched.Context
The behavior #851 describes was already fixed in #829 (merge commit 5a11f40, Oct 1). On
maintoday:WalletScreen.tsxandAccountCard.tsxhave no localcopiedstate and no inline fixed-position toast markup.useToast()(success(...), which wrapsaddToast, anderror(...)inAccountCard).ToastRenderer/ToastContaineris mounted inApp.tsx.The one gap left is the issue's fourth acceptance criterion.
WalletScreen.test.tsxsets up asuccessToastmock but the copy test never asserts it.Changes
src/screens/WalletScreen.test.tsx: after triggering copy, assertsuccessToastis called once with"Address Copied"and the message"The address has been copied to your clipboard."No changes to
WalletScreen.tsx,AccountCard.tsxorToastContext.tsx. I deliberately did not rewritesuccess(...)asaddToast({ type: "success", ... }), sincesuccessis a thin wrapper and the behavior is identical.Acceptance criteria mapping
useToast()success/errorwrappers)ToastContainerhandles all toastsApp.tsx)AccountCard.test.tsxalready did)How to verify
npm test -- src/screens/WalletScreen.test.tsxsuccess(...)call from theonCopyhandler inWalletScreen.tsxand see the test fail.Testing
npm run lintnpm run typechecknpm run buildnpm run sizenpm run test:exportsnpm test(Tick each box only after seeing the command pass.)