Repository navigation
fix(ui): toast stacking/pause, chart focus, QR download, error copy, hook polling, wallet detection - #1017
Merged
Conversation
…hook polling, wallet detection (Sorokit#952, Sorokit#953, Sorokit#954, Sorokit#955) - Sorokit#952 Toast: reference-counted pause/resume of auto-dismiss on hover/focus, Escape to dismiss, stacked layout - Sorokit#953 PieChart focus-visible slice rings; QRCode accessible description + Download QR; ErrorBoundary "Copy error details" - Sorokit#954 SorokitProvider: detect wallets injected after mount (stellar#initialized + bounded poll) via detectedWallets, abort in-flight account queries on switch/address change - Sorokit#955 useFeeData pause on tab hidden, useOutsideClick target rebinding, useIsVisible threshold/rootMargin/root options
|
@devsimze Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Combined fix for four UI issues. All changes are covered by tests;
npm run typecheck,npm run lint, and the changed/related test files (181 passing) are green.#952 — Prevent toast stacking overlap and pause auto-dismiss on hover
pauseToast/resumeToastinToastContextso overlapping pause sources don't prematurely resume.Toastpauses the auto-dismiss timer on hover/focus and resumes from the remaining time on leave/blur; Escape dismisses.#953 — Keyboard slice focus, QR download, error copying
PieChart: slices get afocus-visiblering and brand stroke for keyboard users.QRCode: linked visually-hiddendescriptionviaaria-describedby, plus a "Download QR" action (independent of clipboard).ErrorBoundary: "Copy error details" button with anexecCommandfallback and "Copied!" feedback.#954 — Delayed wallet injection + abort in-flight queries
SorokitProviderdetects wallet extensions injected after mount (seed on mount,stellar#initializedevents, plus a bounded 200ms poll) and exposes them viadetectedWallets.AbortControlleron network switch / address change / disconnect, guarding against stale state and swallowing superseded rejections.#955 — Pause background polling + listener optimizations
useFeeData: pauses polling while the tab is hidden (visibilitychange) and refreshes when visible again.useOutsideClick: optional explicittargetargument rebinds listeners when the element identity changes.useIsVisible: acceptsthreshold,rootMargin, androotoptions.Test plan
npx vitest run— changed/related files: 181 passed. Full suite green in isolation (a small number of unrelated, heavily-mocked test files can time out at 10s under host CPU contention only).npm run typecheck— cleannpm run lint— cleanCloses #952
Closes #953
Closes #954
Closes #955