Skip to content

fix: validate DID documents and normalize SDK errors - #887

Merged
Just-Bamford merged 2 commits into
Sorokit:mainfrom
Faisat-Creator:main
Oct 22, 2026
Merged

Just-Bamford merged 2 commits into
Sorokit:mainfrom
Faisat-Creator:main

Conversation

@Faisat-Creator

Copy link
Copy Markdown
Contributor

Summary

  • Validate DID documents returned by custom resolvers.
  • Document required SDK initialization and opt-in configuration.
  • Add a shared adapter for converting thrown exceptions into SorokitResult errors.
  • Add regression tests for DID validation and result normalization.

Issues

Closes #784
Closes #793
Closes #794

Validation

  • corepack yarn vitest run src/tests/didSupport.test.ts src/tests/result.test.ts --coverage.enabled=false
  • 2 test files passed
  • 89 tests passed
  • corepack yarn typecheck
  • git diff --check

Faisat-Creator and others added 2 commits October 22, 2026 07:45
@drips-wave

drips-wave Bot commented Oct 22, 2026

Copy link
Copy Markdown

@Faisat-Creator Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@Just-Bamford
Just-Bamford merged commit 1acd4ff into Sorokit:main Oct 22, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants