Skip to content

fix: tighten TypeScript and package API boundaries - #880

Merged
Just-Bamford merged 2 commits into
Sorokit:mainfrom
Dev-AdeTutu:main
Oct 21, 2026
Merged

Just-Bamford merged 2 commits into
Sorokit:mainfrom
Dev-AdeTutu:main

Conversation

@Dev-AdeTutu

Copy link
Copy Markdown
Contributor

Summary

This PR hardens the SDK's type-safety and package API boundaries across the repository:

  • Makes the important strict TypeScript compiler checks explicit so type-safety regressions are caught consistently.
  • Pins @stellar/stellar-sdk to 13.3.0 in both the development and peer dependency manifests, with the lockfile updated to match.
  • Aligns the sorokit-core/shared package export with a generated curated public entrypoint instead of exposing the broad internal shared barrel. Internal shared utilities remain available to the implementation but are no longer part of the consumer-facing stability surface.
  • Extends export validation to load the curated shared entrypoint and reject accidental leakage of internal cache/registry utilities.

Validation

  • npm run typecheck
  • npm run build
  • npm run validate:exports
  • Full Vitest run: 3,831 tests passed; one existing timing-sensitive retry assertion missed its threshold by 1 ms. The isolated retry test passes.

Closes #797
Closes #796
Closes #795
Closes #792

Dev-AdeTutu and others added 2 commits October 21, 2026 06:34
@drips-wave

drips-wave Bot commented Oct 21, 2026

Copy link
Copy Markdown

@Dev-AdeTutu Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@Just-Bamford
Just-Bamford merged commit 6fb13a4 into Sorokit:main Oct 21, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment